Add Inbound field to admin_peers rpc call response #7443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -43,13 +45,13 @@ public PeerInfo(Peer peer, bool includeDetails) | |||
| IsBootnode = peer.Node.IsBootnode; | |||
| IsStatic = peer.Node.IsStatic; | |||
| Enode = peer.Node.ToString(Node.Format.ENode); | |||
| Inbound = peer.InSession is not null && peer.InSession.Direction == ConnectionDirection.In; // assumes one of InSession/Outsession is always set.? | |||
There was a problem hiding this comment.
all InSession should have direction.In
| EthDetails = peer.Node.EthDetails; | ||
| LastSignal = (peer.InSession ?? peer.OutSession)?.LastPingUtc.ToString(CultureInfo.InvariantCulture); | ||
| } | ||
| if (!includeDetails) return; |
There was a problem hiding this comment.
personal: I dislike jumping out from methods in the middle (it is okayish at the begining).
| @@ -15,7 +15,7 @@ public class PeerInfo | |||
| public string Host { get; set; } | |||
| public int Port { get; set; } | |||
| public string Address { get; set; } | |||
| public bool IsBootnode { get; set; } | |||
| public bool IsBootnode { get; set; } // change to BootNode (capitalize "N")? | |||
There was a problem hiding this comment.
We can change, but what is the standard?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7317
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Previous tests where smoke tests and redundant, followed the pattern.
Documentation
Requires documentation update
Link to docs update: NethermindEth/docs#223
Requires explanation in Release Notes